Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters for table and tbody attributes in GridView #133

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 22, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (912e2d9) 99.87% compared to head (c661d61) 98.60%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/GridView.php 26.92% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     99.87%   98.60%   -1.27%     
- Complexity      474      477       +3     
============================================
  Files            20       20              
  Lines          1559     1577      +18     
============================================
- Hits           1557     1555       -2     
- Misses            2       22      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team November 22, 2023 13:33
@vjik vjik added the status:code review The pull request needs review. label Nov 22, 2023
Copy link

what-the-diff bot commented Nov 22, 2023

PR Summary

  • Added New Theme Configuration for Widgets
    We have added a new configuration element 'widgets-themes' to the composer.json file. This will allow users to customize their widget themes more effectively.

  • Created Configuration File for Widget Themes
    A new files called 'widgets-themes.php' has been created in the 'config' directory. This file will handle all the settings related to the newly added widget themes.

  • Enhancements to GridView Class
    New methods and properties have been added to the 'GridView' class in the 'GridView.php' file to facilitate better grid data representation. Also, the 'renderTableBody' method within this class has been updated to improve the way data is rendered within the grid.

  • Updated Test Cases
    Various tests for classes like 'ActionColumn', 'CheckboxColumn', 'DataColumn', 'RadioColumn', and 'DataColumnFilter' have been updated to ensure that the new code changes work properly without causing any unintended consequences.

  • HTML Markup Changes in Test Files
    The HTML markup used in various test cases across several files (like tests/GridView/BaseTest.php,tests/GridView/TranslatorTest.php, tests/Pagination/KeysetPaginationBaseTest.php, tests/Pagination/OffsetPaginationBaseTest.php) has been updated. We have changed the table class from <table class="table"> to just <table>. These updates should lead to better compatibility and cleaner code.

@vjik vjik merged commit c034c08 into master Nov 22, 2023
23 of 25 checks passed
@vjik vjik deleted the improve branch November 22, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants